Add ability to enable remote profiling using pprof #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Suleymanov <[email protected]>
|
Hey folks! We're experimenting using kine with CockroachDB and I've run into OOMs with kine using up to 2GB of RAM in some situations. This seems to be related to #87, since kine officially does not support CockroachDB. That said, I'm looking into ways to improve peak memory usage, but I've noticed that there's no way to do remote profiling, so I've made this small change to enable it. I've already tested this internally with https://hub.docker.com/repository/docker/radioheads/kine, but I'm happy to provide more info if necessary. |
brandond
reviewed
Oct 20, 2022
brandond
reviewed
Oct 20, 2022
Signed-off-by: Igor Suleymanov <[email protected]>
brandond
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a new flag, which, when enabled, allows for remote profiling using
net/http/pprofpackage, with the handlers mounted to the metrics server.By default the flag is disabled, to ensure that the change is backwards-compatible.
Why
This allows for ad-hoc and continuous (e.g. using https://pyroscope.io/) profiling, which is useful for finding memory / cpu bottlenecks.